Comments for Jorge Manrubia

Comment on Using delayed_job with Cucumber by Jorge Manrubia

Jorge Manrubia — Wed, 26 Oct 2011 09:24:02 +0000

Hi Phil. I am using a :deletion strategy. Anyway, I was using a :transaction strategy before and I didn’t have problems with delayed_job. You can aslo leave delayed_job out of the deletion strategy if you use the :except option (I don’t do it). Thanks for your feedback

Comment on Using delayed_job with Cucumber by Phil

Phil — Tue, 25 Oct 2011 20:10:16 +0000

I like this idea but the only problem with this approach is that you can’t then use the transaction database_cleaner strategy.

Comment on Dependency injection and other Java necessary evils by solid_assert: A simple Ruby assertion utility - Jorge Manrubia

solid_assert: A simple Ruby assertion utility - Jorge Manrubia — Mon, 19 Sep 2011 23:05:05 +0000

[...] the same thing with dependency injection frameworks. But, while after a time working with Ruby I was convinced that I didn’t need a dependency injection framework, I still miss assertions when programming [...]

Comment on Dependency injection and other Java necessary evils by Asbjørn

Asbjørn — Sun, 11 Sep 2011 21:32:11 +0000

This is not a problem when using a stubbing-tool that doesn’t need injection

Comment on Comparing EMF Models by Jorge Manrubia

Jorge Manrubia — Sun, 07 Aug 2011 11:20:47 +0000

Thank you Fabian. Your approach seems much better. Thanks for sharing it!

Comment on Comparing EMF Models by Fabian

Fabian — Thu, 04 Aug 2011 08:50:49 +0000

Hi, the sorting didn’t worked for my EObjects, i think its sometimes not enough to take the Standard toString Method to sort by. So I have written my own EqualityHelper that really compares the two Lists without a care of order if the Ordered Attribute of the Reference is false. It works finde

import java.util.*;
import org.eclipse.emf.ecore.EObject;
import org.eclipse.emf.ecore.EReference;
import org.eclipse.emf.ecore.EStructuralFeature;
import org.eclipse.emf.ecore.util.EcoreUtil;
import org.eclipse.emf.ecore.util.EcoreUtil.EqualityHelper;

public class CustomEqualityHelper extends EcoreUtil.EqualityHelper {

private static final long serialVersionUID = 1L;

public CustomEqualityHelper() {
super();
}

private CustomEqualityHelper(CustomEqualityHelper emfComparator) {
this.putAll(emfComparator);
}

@SuppressWarnings("unchecked")
@Override
protected boolean haveEqualReference(EObject eObject1, EObject eObject2, EReference reference)
{
Object value1 = eObject1.eGet(reference);
Object value2 = eObject2.eGet(reference);

if(reference.isMany())
{
// *** important change for Unordered Lists here:
if(reference.isOrdered())
return equals((List<EObject>)value1, (List<EObject>)value2);
else
return equalsUnOrdered((List<EObject>)value1, (List<EObject>)value2);
}
else
{
return equals((EObject)value1, (EObject)value2);
}

}

public boolean equalsUnOrdered(List<EObject> list1, List<EObject> list2)
{
// if the Lists haven't the same size they can't be equal
if(list1.size()!=list2.size()) return false;

// save the Equal pairs: list1 Elements as Key and list2 Elements as Value
Map<EObject,EObject> equalFound = new HashMap<EObject,EObject>();

for(EObject list1El:list1)
{
// try to find an equal Element for list1El in list2
for(EObject list2El:list2)
{
// skip Elements of list2 that already have an equal Element in list1
if(!equalFound.containsValue(list2El))
// if list list1El is equal to list2El save it the Map
// create a copy of the CustomEqualityHelper because it's made only for one recursive Compare
if(new CustomEqualityHelper(this).equals(list1El, list2El))
{
equalFound.put(list1El, list2El);
break;
}
}

// if no equal Element for listEl1 was found in list2, they couldn't be equal
if(!equalFound.containsKey(list1El)) return false;

}

// For all Elements of list1 an own equal Element in list2 was found.
return true;

Comment on Using delayed_job with Cucumber by Jorge Manrubia

Jorge Manrubia — Tue, 26 Apr 2011 14:53:56 +0000

Ey Sean, thanks for the tip. It looks cleaner. By the way, I am currently running cucumber features in parallel using the parallel_tests gem

Comment on Using delayed_job with Cucumber by Sean

Sean — Tue, 26 Apr 2011 13:22:34 +0000

I’ve had to do this as well and approached it in a slightly different way. See http://lineonpoint.com/2010/10/26/run-cucumber-scenarios-paralell/

This should resolve your RAILS_ENV issue, and gives dealyed_job a chance to shutdown gracefully.

It can be called with CucumberDelayedJob.start and CucumberDelayedJob.stop_worker in your Before and After hooks.

Comment on Using delayed_job with Cucumber by Jorge Manrubia

Jorge Manrubia — Fri, 22 Apr 2011 06:53:36 +0000

Thank you very much for the feedback and for the tip. There is already a method ‘wait_until’ in capybara that does exactly that. It waits for something to be true, or raises a timeout exception if the condition is not satisfied in the specified period of time. Your example could be rewritten like this:

wait_until(11) { has_content?(content) }

Comment on Using delayed_job with Cucumber by Missing Handle

Missing Handle — Thu, 21 Apr 2011 21:42:03 +0000

In return, I contribute this cucumber step I just came up with to be as efficient as possible in waiting for delayed_job jobs:

Then /^the wait dance on "([^"]<em>)" for "([^"])" should be successful$/ do |path, content|
success = false
11.times do
visit path
success = true and break if page.has_content?(content)
sleep 1
end
success.should be_true
end