By: Errors in my post on Comparing EMF Models - Jorge Manrubia

Errors in my post on Comparing EMF Models - Jorge Manrubia — Sun, 08 Feb 2009 01:06:16 +0000

[...] was an error in the code originally posted in my article on Comparing EMF models. Thank you so much to Jim Showalter for warning me. The post has been updated with the right code. [...]

By: Code Reviewer

Code Reviewer — Wed, 19 Nov 2008 01:09:17 +0000

This code doesn’t actually work. If you look at the chain of calls, you’re basically doing: replace o1.toString().hashCode() in o1.toString(), but o1.toString() contains the hashCode of o1, not of o1′s toString(). Also, there’s no reason to replace the class name, and even if there was you’re replacing o1.toString().getClass().getName(), which will always return java.lang.String, when what you want is to replace o1.getClass().getName(). And even if you get both replaces working, ordering will fail when comparing two models generated from the same diagram but with different seeds for the IDs, because the IDs won’t match, so the sorts won’t match.”

Comments on: Comparing EMF Models

By: Errors in my post on Comparing EMF Models - Jorge Manrubia

By: Code Reviewer